Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: add container-registry settings extension #3674

Merged

Conversation

sam-berning
Copy link
Contributor

Issue number:

Closes # #3658

Description of changes:

Ports container-registry settings to a settings extension. Creates a basic binary for the extension and a package that can install it.

Testing done:

  • built aws-dev variant with the settings-container-registry package included
  • checked that the expected defaults (none in this case) were set
  • made changes to the setting with apiclient set -j '{"container-registry": {"mirrors": [{"registry": "foo", "endpoint": ["bar"]}]}'
  • validated that the settings extension binary at /usr/libexec/settings/container-registry worked as expected

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sam-berning sam-berning merged commit 53b709f into bottlerocket-os:develop Dec 22, 2023
46 checks passed
@jpculp jpculp mentioned this pull request Jan 4, 2024
11 tasks
@stockholmux
Copy link
Member

@sam-berning Just to confirm, this has no end-user impact on the setting?

We don't need to change the docs as outlined here: https://bottlerocket.dev/en/os/1.17.x/api/settings/container-registry/

@sam-berning
Copy link
Contributor Author

Yep, that's right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants