-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host container update for v1.17.0 #3646
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
suggested changes
Dec 7, 2023
jpculp
force-pushed
the
1.17.0-host-containers
branch
2 times, most recently
from
December 7, 2023 20:14
db7e313
to
2c81512
Compare
cbgbt
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems right to me, assuming testing goes well.
etungsten
suggested changes
Dec 7, 2023
sources/api/migration/migrations/v1.17.0/aws-admin-container-v0-11-2/src/main.rs
Outdated
Show resolved
Hide resolved
sources/api/migration/migrations/v1.17.0/aws-control-container-v0-7-6/src/main.rs
Outdated
Show resolved
Hide resolved
jpculp
force-pushed
the
1.17.0-host-containers
branch
from
December 7, 2023 21:13
2c81512
to
0157a90
Compare
Tested migrations and host-containers source image URLS are updated correctly: Upgrade:
Downgrade: bash-5.1# signpost rollback-to-inactive
bash-5.1# reboot
[ssm-user@control]$ apiclient get os
{
"os": {
"arch": "x86_64",
"build_id": "763f6d4c",
"pretty_name": "Bottlerocket OS 1.16.1 (aws-k8s-1.28)",
"variant_id": "aws-k8s-1.28",
"version_id": "1.16.1"
}
}
[ssm-user@control]$ apiclient get settings.host-containers
{
"settings": {
"host-containers": {
"admin": {
"enabled": true,
"source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-admin:v0.11.1",
"superpowered": true,
"user-data": "
},
"control": {
"enabled": true,
"source": "328549459982.dkr.ecr.us-west-2.amazonaws.com/bottlerocket-control:v0.7.5",
"superpowered": false
}
}
}
}
|
etungsten
approved these changes
Dec 7, 2023
cbgbt
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update the default admin and control container images to v0.11.2 and v0.7.6 respectively.
Testing done:
cargo make check-migrations
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.