Fix for invalid chars when returning IPv6 hostname #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netdog will return an IPv6 address string in some corner cases. Replace colons with dashes to ensure the string will validate as ValidLinuxHostname.
yeazelm
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #3571
Description of changes:
Netdog will return an IPv6 address string in some corner cases. Replace colons with dashes to ensure the string will validate as ValidLinuxHostname.
Testing done:
Validated locally when no valid IPv4 is assigned by
systemd-networkdbut a valid IPv6 is assigned whensystemd-networkd-wait-online.servicetimes out that the string netdog returns can be validated as ValidLinuxHostnameTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.