build: allow skipping of twoliter install #3392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Amends #3342
Description of changes:
The cargo install of Twoliter was causing a call out to the git repository even if Twoliter was already installed. This is a problem in intentionally offline environments.
Furthermore, in the future we plan to curl a binary release of Twoliter, which means we will need a way to skip the installation there as well.
This commit introduces a Makefile.toml variable
SKIP_TWOLITER_INSTALL which can be used to skip the installation of Twoliter when it has already been installed.
Testing done:
Try to install with
true
but without Twoliter installed. Fails as expected.Run fetch without skipping installation. Twoliter is installed.
Now try fetch again with skip install true:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.