Only limit concurrency while building RPMs #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
approved these changes
Aug 12, 2023
yeazelm
approved these changes
Aug 13, 2023
zmrow
approved these changes
Aug 14, 2023
I still think it makes sense to limit concurrency for |
cbgbt
force-pushed
the
unleash-the-builds
branch
from
d48e8e3
to
b9a0529
Compare
cbgbt
changed the title
cargo make build-variant and build-package typically run several RPM builds concurrently, and those allow for their own levels of parallelism. Leaving this unrestricted would very easily lead to context switching overhead. On the other hand, the rest of the build commands are mostly focused on building a directory of rust sources. It shouldn't be a problem to let cargo use as many cores as it needs for those.
cbgbt
force-pushed
the
unleash-the-builds
branch
from
b9a0529
to
e13d557
Compare
|
bcressey
approved these changes
Aug 14, 2023
cbgbt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
cargo make build-variant and build-package typically run several RPM builds concurrently, and those allow for their own levels of parallelism. 8 concurrent jobs (though unscientifically decided) still seems like a reasonable limitation there.
On the other hand, the rest of the build commands mostly focus on building a directory of rust sources. It shouldn't be a problem to let cargo use as many cores as it needs for those.
Testing done:
This seems to make
cargo make tuftoolandcargo make publish-setupfaster when you don't have any of their dependencies' builds cached.On my (admittedly beefy) machine:
Without change:
cargo make tuftool152 secondscargo make publish-setup-tools60 secondsWith change:
cargo make tuftool131 secondscargo make publish-setup-tools38.72 secondsTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.