Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: add random delay to matrix start #3248

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

stmcginnis
Copy link
Contributor

Issue number:

N/A

Description of changes:

For our main "build" GitHub Action we build a matrix execution for each variant supported. This causes many jobs to start at the same time, and could lead to triggering some protections from the external resources that they need to pull from (GitHub, crates.io, etc).

This adds a random delay up to 30 seconds to the individual variant runs so they don't all kick off the same actions at the same time, hopefully spreading some of the load a little better and avoiding some of these backoff protections.

Testing done:

To be seen in resulting action runs.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@stmcginnis stmcginnis requested a review from bcressey July 5, 2023 16:04
Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎲

.github/workflows/build.yml Outdated Show resolved Hide resolved
For our main "build" GitHub Action we build a matrix execution for each
variant supported. This causes many jobs to start at the same time, and
could lead to triggering some protections from the external resources
that they need to pull from (GitHub, crates.io, etc).

This adds a random delay up to 30 seconds to the individual variant runs
so they don't all kick off the same actions at the same time, hopefully
spreading some of the load a little better and avoiding some of these
backoff protections.

Signed-off-by: Sean McGinnis <[email protected]>
Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is no longer accurate about the 30 seconds, but it's inconsequential

@stmcginnis stmcginnis merged commit dd71ac0 into bottlerocket-os:develop Jul 6, 2023
38 checks passed
@stmcginnis stmcginnis deleted the action-randomize branch July 6, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants