Update clap and remove use of structopt in tools #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
reviewed
Jun 26, 2023
zmrow
reviewed
Jun 26, 2023
jpculp
reviewed
Jun 26, 2023
Signed-off-by: Sean McGinnis <[email protected]>
Updates clap in pubsys and removes structops. Signed-off-by: Sean McGinnis <[email protected]>
Tweaks for the newer version of clap. Signed-off-by: Sean McGinnis <[email protected]>
This removes the structopt dependency in favor of clap. Signed-off-by: Sean McGinnis <[email protected]>
jpculp
approved these changes
Jun 28, 2023
etungsten
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Related #2373
Description of changes:
This updates our
tools/binaries to use the latest version of theclapcrate. It also drops the use ofstructoptas that project is now in maintenance mode:So this standardizes our out-of-distro tools to just use the latest
clap.Note: unfortunately we need to pull in two different versions of
clapdue to our use ofgenerate-readme. That project is no longer maintained as well, so we will either need to find a replacement or stop using it to generate README files.Testing done:
Built all binaries. Compared
$bin --helpoutput between the old and new versions to verify there were no non-aesthetic differences.Ran
cargo make && cargo make amito make sure project could still be built and published.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.