Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.14.x] Wicked: improve reliability of acquiring a DHCPv6 lease #3212

Merged
merged 3 commits into from
Jun 20, 2023
Merged

[1.14.x] Wicked: improve reliability of acquiring a DHCPv6 lease #3212

merged 3 commits into from
Jun 20, 2023

Commits on Jun 19, 2023

  1. wicked: cherry-pick fix to unconditionally poll for link updates 

    Wicked may miss that the kernel received a Router Advertisement while
waiting for a device to become ready for DHCPv6. It will then wait
indefinitely and never enter the FSM.

Cherry-pick the upstream fix to unconditionally poll for link updates
rather than only relying on netlink updates being pushed to Wicked in
non-dry-run mode.

Signed-off-by: Markus Boehme <[email protected]>
(cherry picked from commit 3c822fb)
    @markusboehme @stmcginnis
    markusboehme authored and stmcginnis committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    78a53ce View commit details
    Browse the repository at this point in the history

  2. wicked: fix occasional hang during DHCPv6 solicitation 

    This fixes an occasional hang during DHCPv6 solicitation when the
randomized initial soliciation delay happened to be exactly 0 ms.

The patch can be upstreamed.

Signed-off-by: Markus Boehme <[email protected]>
(cherry picked from commit 53fe4ae)
    @markusboehme @stmcginnis
    markusboehme authored and stmcginnis committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    939dd1b View commit details
    Browse the repository at this point in the history

  3. wicked: reduce initial DHCPv6 solicitation delay to 100 ms 

    Reduce the maximum initial solicitation delay to 100 ms from the
spec-mandated value of 1000 ms to reduce the average and variance in
time to node readiness.

This is not strictly compliant with RFC 3315 (treating the initial delay
as a MUST), and only tolerated by its successor RFC 8415 (changing it to
a SHOULD). This change therefore is not a good candidate for upstreaming.

Signed-off-by: Markus Boehme <[email protected]>
(cherry picked from commit 01a3274)
    @markusboehme @stmcginnis
    markusboehme authored and stmcginnis committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    215c206 View commit details
    Browse the repository at this point in the history