Wicked: improve reliability of acquiring a DHCPv6 lease #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wicked may miss that the kernel received a Router Advertisement while waiting for a device to become ready for DHCPv6. It will then wait indefinitely and never enter the FSM. Cherry-pick the upstream fix to unconditionally poll for link updates rather than only relying on netlink updates being pushed to Wicked in non-dry-run mode. Signed-off-by: Markus Boehme <[email protected]>
This fixes an occasional hang during DHCPv6 solicitation when the randomized initial soliciation delay happened to be exactly 0 ms. The patch can be upstreamed. Signed-off-by: Markus Boehme <[email protected]>
Reduce the maximum initial solicitation delay to 100 ms from the spec-mandated value of 1000 ms to reduce the average and variance in time to node readiness. This is not strictly compliant with RFC 3315 (treating the initial delay as a MUST), and only tolerated by its successor RFC 8415 (changing it to a SHOULD). This change therefore is not a good candidate for upstreaming. Signed-off-by: Markus Boehme <[email protected]>
bcressey
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #3143 (this is the second piece for #3159)
Description of changes:
This PR contains changes to improve the reliability and efficiency of getting a DHCPv6 lease for an interface via Wicked. The three patches are an upstream backport, a downstream fix (to be upstreamed), and a downstream modification (not to be upstreamed). For details, please see the respective commits.
Testing done: Most extensively by @zmrow in #3159 (thanks!)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.