netdog: add primary-interface argument #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
reviewed
May 1, 2023
This argument provides the configured primary interface. This command provides a way to get the machine's primary interface without reading the files directly which provides a CLI API to access this value. This will be used in yet to be implemented logic to watch this interface for changes on D-Bus.
bcressey
approved these changes
May 4, 2023
| /// Return the current IP address | ||
| pub(crate) struct PrimaryInterfaceArgs {} | ||
|
|
||
| /// Return the current IP address as JSON (intended for use as a settings generator) |
There was a problem hiding this comment.
nit: this comment seems like a copy/paste artifact, since I don't really see how we could use a settings generator for primary interface.
Suggested change
| /// Return the current IP address as JSON (intended for use as a settings generator) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2449 has a sub task for D-Bus listener, this is part 2 of this change.
Closes #
Description of changes:
This command provides a way to get the machine's primary interface without reading the files directly which provides a CLI API to access this value. This will be used in yet to be implemented logic to watch this interface for changes on D-Bus.
Testing done:
cargo build, fmt, clippy, and test to ensure everything passes. This command isn't in play unless systemd-networkd is configured.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.