Add kubernetes-1.27 package and variants #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gthao313
reviewed
May 4, 2023
gthao313
reviewed
May 4, 2023
jpmcb
reviewed
May 4, 2023
bcressey
reviewed
May 5, 2023
Comment on lines
+1
to
+9
| [Service] | ||
| # Pull the pause container image before starting `kubelet` so `containerd/cri` wouldn't have to | ||
| ExecStartPre=/usr/bin/host-ctr \ | ||
| --containerd-socket=/run/containerd/containerd.sock \ | ||
| --namespace=k8s.io \ | ||
| pull-image \ | ||
| --source=${POD_INFRA_CONTAINER_IMAGE} \ | ||
| --registry-config=/etc/host-containers/host-ctr.toml \ | ||
| --skip-if-image-exists=true |
There was a problem hiding this comment.
Just curious - do we have a path for getting rid of this at some point? It seems weird that kubelet can't handle this.
There was a problem hiding this comment.
I'm not familiar with it. We should discuss with someone that has more background on the need for it in the first place. If it is not actually needed we should be able to remove it in a follow on patch.
stmcginnis
force-pushed
the
k8s-1.27
branch
2 times, most recently
from
c10ac77
to
cb6d7e0
Compare
bcressey
approved these changes
May 5, 2023
This adds a new package for installing k8s 1.27. It also adds all variants for the *-k8s-* variant. Signed-off-by: Sean McGinnis <[email protected]>
This was referenced May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
This adds a new package for installing k8s 1.27. It also adds all variants for the -k8s- variant.
Testing done:
metal-k8s-1.27validationvmware-k8s-1.27validationTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.