1.13.x: Merge in pubsys changes
#2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This surfaces the actual AWS API service error code in the error log message.
The EC2 API call for modify-snapshot-attribute and modify-image-attribute errors on empty vecs. This passes 'None' for the list parameters if the list is empty.
Ensure we pass None if the list of names we're passing is empty.
pubsys: fix AWS SDK API calls and surface service error codes
jpmcb
changed the title
v1.13.x: Merge in pubsys changes1.13.x: Merge in pubsys changes
jpmcb
requested review from
jpculp,
etungsten,
rpkelly,
bcressey and
stmcginnis
and removed request for
jpculp,
etungsten and
rpkelly
stmcginnis
approved these changes
Mar 15, 2023
jpculp
approved these changes
Mar 15, 2023
etungsten
approved these changes
Mar 15, 2023
rpkelly
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/a - brings in changes from
developDescription of changes:
pubsyschanges for v1.13 releaseWe can also use the "Rebase and merge" strategy to avoid an additional merge commit.
Testing done:
N/a - see testing in #2895
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.