Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsys 0.0.6 #2865

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Testsys 0.0.6 #2865

merged 1 commit into from
Mar 8, 2023

Conversation

ecpullen
Copy link
Contributor

@ecpullen ecpullen commented Mar 7, 2023

Issue number:

N/A

Description of changes:

Updates the testsys cli to use TestSys v0.0.6 - https://github.com/bottlerocket-os/bottlerocket-test-system/releases/tag/v0.0.6

Testing done:

Ran cargo make test with aws-ecs-1 and verified that testing completed successfully. All agents were tested as part of the TestSys v0.0.6 release.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@ecpullen ecpullen force-pushed the testsys-0.0.6 branch 2 times, most recently from f5c96ee to 7e7701e Compare March 7, 2023 22:27
@ecpullen ecpullen requested a review from jpculp March 7, 2023 22:27
Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you rebase and run cargo update -p [email protected] --precise 0.3.19 in tools we can finally drop that time v0.1.x dependency. You'll also want to delete ⤵︎

{ name = "time", version = "=0.1.43" },

@ecpullen ecpullen force-pushed the testsys-0.0.6 branch 2 times, most recently from 41717ba to 0a3d80c Compare March 8, 2023 03:09
@ecpullen
Copy link
Contributor Author

ecpullen commented Mar 8, 2023

Checking Cargo.lock, I see that we have removed the extra time. Interestingly, I didn't need to run cargo update. I just needed to rebase and run cargo check. Based on the actions failure, I think I forgot to let the Cargo.lock update after manually updating TestSys.

@ecpullen ecpullen requested a review from jpculp March 8, 2023 03:14
Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just needed to rebase and run cargo check.

Also works!

@ecpullen ecpullen merged commit 46c01b2 into bottlerocket-os:develop Mar 8, 2023
@ecpullen ecpullen deleted the testsys-0.0.6 branch March 8, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants