Makefile: use SDK for Rust formatting #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsterckx
force-pushed
the
sdk-rust-formatting
branch
2 times, most recently
from
850335a
to
b0c434f
Compare
jpculp
reviewed
Apr 11, 2023
mjsterckx
force-pushed
the
sdk-rust-formatting
branch
from
b0c434f
to
ce5eb68
Compare
jpculp
approved these changes
Apr 12, 2023
jpmcb
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2846
Description of changes:
Changed the
rustfmtused in thecheck-fmttarget for Rust formatting to the one included in the BUILDSYS_SDK to avoid conflicting lints between local builds and GitHub actions.Testing done:
Ran cargo make check-fmt locally.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.