Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated rust_2018_idioms enforcement #2837

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

stmcginnis
Copy link
Contributor

Issue number:

N/A

Description of changes:

The #![deny(rust_2018_idioms)] tag was used to help move from Rust 2015 style code to 2018. We've already moved beyond that and clippy flags much more than that. Since these are now useless, this cleans up all instances in the code where we were using this tag.

Testing done:

Ran cargo make check to run lints and unit tests.
Created an aws-k8s-1.24 image, deployed cluster, and verified everything came up fine and able to deploy a test workload.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

The `#deny[rust_2018_idiom]` tag was used to help move from Rust 2015
style code to 2018. We've already moved beyond that and clippy flags
much more than that. Since these are now useless, this cleans up all
instances in the code where we were using this tag.

Signed-off-by: Sean McGinnis <[email protected]>
@stmcginnis stmcginnis merged commit 9b3d9c9 into bottlerocket-os:develop Feb 28, 2023
@stmcginnis stmcginnis deleted the 2018-idioms branch February 28, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants