Enable firelens capability in aws-ecs-1 variant #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
ecs-agent-logging
branch
from
5915e93
to
79168c3
Compare
yeazelm
approved these changes
Feb 22, 2023
arnaldo2792
approved these changes
Feb 22, 2023
cbgbt
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #1079
Description of changes:
Report FireLens capabilities in the
amazon-ecs-agent. This enables using FireLens in ECS with a Bottlerocket container instance.Testing done:
Deployed task definition with
log_routerand workload container using the CloudWatch example configuration. Verified log group was created in CloudWatch Logs and that it contained expected output. Checked Bottlerocket instance journal logs and verified no unusual errors there.Huge thanks to @arnaldo2792 for running through various testing scenarios:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.