Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes k8s.gcr.io in favor of registry.k8s.io #2786

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Feb 8, 2023

Issue number:

N/a - k8s.gcr.io is being deprecated in favor of registry.k8s.io.
See: https://kubernetes.io/blog/2023/02/06/k8s-gcr-io-freeze-announcement/

Description of changes:

Replaces registry for pause image. Image is present:

❯ crane ls registry.k8s.io/pause
0.8.0
1.0
2.0
3.0
3.1
3.2
3.3
3.4.1
3.5
3.6
3.7
3.8
3.9
go
latest
sha256-7031c1b283388d2c2e09b57badb803c05ebed362dc88d84b480cc47f72a21097.sig
sha256-9001185023633d17a2f98ff69b6ff2615b8ea02a825adffa40422f51dfdcde9d.sig
test
test2

Testing done:

What testing should we do here since this only affects defaults for vmware k8s?

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpmcb jpmcb marked this pull request as draft February 8, 2023 16:10
@jpmcb
Copy link
Contributor Author

jpmcb commented Feb 8, 2023

Drafting this to address this setting needing a migration

@jpmcb jpmcb force-pushed the remove-old-k8s-reg branch 2 times, most recently from a3c4845 to 4249a09 Compare February 13, 2023 16:43
@jpmcb jpmcb marked this pull request as ready for review February 13, 2023 16:43
@jpmcb
Copy link
Contributor Author

jpmcb commented Feb 13, 2023

Force pushed to add migration for the settings.kubernetes.pod-infra-container-image

Testing incoming!!

@jpmcb
Copy link
Contributor Author

jpmcb commented Feb 13, 2023

Force pushed to add missing update to Cargo.lock

- Adds migration for settings.kubernetes.pod-infra-container-image

Signed-off-by: John McBride <[email protected]>
@jpmcb
Copy link
Contributor Author

jpmcb commented Feb 13, 2023

Force pushed to import correct migration helper. Ok! Now testing should be incoming soon!!

Copy link
Member

@gthao313 gthao313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jpmcb
Copy link
Contributor Author

jpmcb commented Feb 14, 2023

Ran migrations tests for vmware variant with custom built tuf repo and cargo make test -e TESTSYS_TEST=migration ...

 NAME                                                TYPE                    STATE                   PASSED                   SKIPPED                   FAILED                  LAST UPDATE                             BUILD ID
 x86-64-vmware-k8s-122-1-initial                     Test                    pass                    1                        6443                      0                        2023-02-14T17:59:17Z                   3623d422-dirty
 x86-64-vmware-k8s-122-2-migrate                     Test                    pass                    2                        0                         0                        2023-02-14T18:00:14Z                   3623d422-dirty
 x86-64-vmware-k8s-122-3-migrated                    Test                    pass                    1                        6443                      0                        2023-02-14T18:01:02Z                   3623d422-dirty
 x86-64-vmware-k8s-122-4-migrate                     Test                    pass                    2                        0                         0                        2023-02-14T18:01:44Z                   3623d422-dirty
 x86-64-vmware-k8s-122-5-final                       Test                    pass                    1                        6443                      0                        2023-02-14T18:02:33Z                   3623d422-dirty

👍🏼

@jpmcb jpmcb merged commit 9412a77 into bottlerocket-os:develop Feb 14, 2023
@jpmcb jpmcb deleted the remove-old-k8s-reg branch February 14, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants