Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: ensure empty build/rpms directory is included in build context #2784

Merged
merged 1 commit into from
Feb 7, 2023
Merged

build: ensure empty build/rpms directory is included in build context #2784

merged 1 commit into from
Feb 7, 2023

Commits on Feb 7, 2023

  1. build: ensure empty build/rpms directory is included in build context 

    Whether intentionally or not, Docker 23 subtly changed the handling of
negated patterns in `.dockerignore` files. In our case,

    /build/*
    !/build/rpms/*.rpm

will not include `build/rpms` in the build context with Docker 23 if
the `build/rpms` is empty. This breaks the build since the directory is
expected to exist in any case.

Add a couple extra patterns that amount to the desired behavior, whether
run with Docker 23 or prior versions.

Signed-off-by: Markus Boehme <[email protected]>
    @markusboehme
    markusboehme committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1e32717 View commit details
    Browse the repository at this point in the history