add k8s 1.26 variants #2771
Merged
add k8s 1.26 variants #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need update after merging #2774 |
gthao313
force-pushed
the
k8s-1.26
branch
2 times, most recently
from
cd31647
to
0d0a951
Compare
stmcginnis
reviewed
Mar 2, 2023
gthao313
commented
Mar 3, 2023
|
Blocked by EKS team that enable |
stmcginnis
approved these changes
Mar 6, 2023
etungsten
approved these changes
Mar 7, 2023
jpmcb
approved these changes
Mar 7, 2023
|
|
||
| %build | ||
| # Build codegen programs with the host toolchain. | ||
| make hack/update-codegen.sh |
There was a problem hiding this comment.
FYI to others since I was curious:
echo "'make generated_files' is deprecated. Please use hack/update-codegen.sh instead."
And looks like it'll be dropped in k8s 1.29
https://github.com/kubernetes/kubernetes/blob/2dae34c4a2768a8d39422be42eae2b2817a41a7c/build/root/Makefile#L311-L317
This adds a k8s-1.26 package. Existing 1.25 models are moved to be 1.26, with symlinks created for 1.25 models to point to the new locations. Finally, new variants are defined for aws-k8s-1.26, aws-k8s-1.26-nvidia, metal-k8s-1.26, and vmware-k8s-1.26.
stmcginnis
approved these changes
Mar 8, 2023
etungsten
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2770
Description of changes:
Testing done:
To be done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.