Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources: Remove unnecessary time 0.1.x dependency #2748

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Jan 24, 2023

Description of changes:

This commit builds chrono only with the features that we need to avoid pulling in an additional (and older) time dependency.

Inspired by awslabs/tough#506.

Testing done:

Built aws-k8s-1.24 and did an upgrade/downgrade test.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

This commit builds `chrono` only with the features that we need to avoid
pulling in an additional (and older) `time` dependency.
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants