variants: move wicked out of release #2709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The builds caught some I missed. I'll update and also break out the reformatting out from the wicked change. |
This makes the Cargo.toml files for all variants consistent in their order and comments.
We need to move wicked out of release so that we can toggle what network backend a variant uses while working on networkd enablement. This makes it possible to remove wicked from one variant without affecting others or have a variant just for networkd testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: 2449
Closes #
Description of changes:
We need to move wicked out of release so that we can toggle what network backend a variant uses while working on networkd enablement. This makes it possible to remove wicked from one variant without affecting others or have a variant just for networkd testing. This commit also makes the variant Cargo.toml ordering consistent with all variants for clarity and consistency.
The diff is lousy because of the shifting of the files. The only changes should be the addition of wicked to packages included and wicked for dependencies. The rest is commenting and sorting to get them all consistent.
Testing done:
Built all the variants. This should not actually affect the resulting images at all.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.