testsys: Add testsys-image-tag to Test.toml
#2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
reviewed
Dec 12, 2022
| @@ -11,6 +11,9 @@ repo = "default" | |||
| # The registry containing alternate TestSys agent images | |||
| testsys-images-registry = "public.ecr.aws/bottlerocket-test-system" | |||
|
|
|||
| # The tag that should be used with `testsys-images-registry` for image pulls | |||
| testsys-images-registry = "latest" | |||
There was a problem hiding this comment.
Do we push a "latest" tag for the TestSys images? I don't think we do for the other container images we publish under Bottlerocket, should we follow that rule here?
There was a problem hiding this comment.
We do not push to the latest tag. We only push the testsys version. Due to image cacheing in k8s clusters, latest should be used when debugging new images. This feature allows someone testing new agents to specify a tag and a registry instead of explicitly listing each agent.
etungsten
approved these changes
Dec 12, 2022
webern
approved these changes
Dec 12, 2022
jpculp
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Allow users to specify the tag that should be used for testsys image pulls when using an alternate
testsys-image-registry. This is especially useful forbottlerocket-test-systemwhen testing new images.Testing done:
I ran
cargo make teston custom testing images withlatesttag and verified that the images used by the agent were the ones with the correct tag.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.