-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
host-ctr: build masked paths list dynamically #2637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpculp
force-pushed
the
dynamic-masked-paths
branch
from
December 6, 2022 01:01
fbd09d6
to
5f9d3bd
Compare
Just tweaking some wording for clarity. |
yeazelm
reviewed
Dec 6, 2022
arnaldo2792
reviewed
Dec 6, 2022
"/proc/scsi", | ||
}), | ||
// Pass an alternate list of masked paths | ||
withMaskedPaths(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 nice!
jpmcb
reviewed
Dec 6, 2022
Replaces the hardcoded masked paths list with the generated one, less the paths provided
jpculp
force-pushed
the
dynamic-masked-paths
branch
from
December 6, 2022 22:38
5f9d3bd
to
6a3acb3
Compare
|
jpmcb
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😷 👍🏼
arnaldo2792
approved these changes
Dec 7, 2022
yeazelm
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Replaces the hardcoded masked paths list (introduced in #2573) with a generated one.
Testing done:
Built and launched an aarch64 k8s variant on a
c6g.large
and ranlscpu
from the control container./.bottlerocket/rootfs/run/host-containerd/runc/default/control/state.json
:/.bottlerocket/rootfs/run/host-containerd/runc/default/admin/state.json
:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.