diff-kernel-config: handle absolute paths for output directory #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extracting the kernel config of a just built kernel diff-kernel-config would always treat the given output directory as a relative path due to a gratuitous "./" in the path it assembles. This would try to write to the wrong path when the script was actually invoked with an absolute path, most likely making it fail because parent directories wouldn't exist. Correctly handle absolute paths by dropping the "./". Other parts of the code dealing with the output directory already don't care whether it's an absolute or relative path. Signed-off-by: Markus Boehme <[email protected]>
webern
approved these changes
Nov 9, 2022
bcressey
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: n/a
Description of changes: When extracting the kernel config of a just built kernel diff-kernel-config would always treat the given output directory as a relative path due to a gratuitous "./" in the path it assembles. This would try to write to the wrong path when the script was actually invoked with an absolute path, most likely making it fail because parent directories wouldn't exist.
Correctly handle absolute paths by dropping the "./". Other parts of the code dealing with the output directory already don't care whether it's an absolute or relative path.
Testing done: Successfully ran
tools/diff-kernel-configboth with an absolute and a relative path for the output directory.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.