Allow bootstrap containers to manage network configuration #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows bootstrap containers to manage network configuration.
jpculp
changed the title
bcressey
reviewed
Nov 8, 2022
bcressey
reviewed
Nov 8, 2022
Allows bootstrap containers to override network configuration by writing `net.toml` to an alternative location, `/var/lib/netdog/`, which takes precedence over the default `/var/lib/bottlerocket/net.toml`.
jpculp
force-pushed
the
alt-net-config-file
branch
from
caaaf41
to
962bf0d
Compare
|
Implemented @bcressey's suggestion and switched to a |
bcressey
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Gives bootstrap containers the ability to write files to
/var/lib/netdog. This can serve as an alternative/overriding location to store anet.toml.Also cleans up some
clippywarnings.Testing done:
Bootstrap container was able to configure network by outputting a
/var/lib/netdog/net.tomlfile.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.