kernel: add driver support for aws variants in hybrid environments #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Nov 7, 2022
foersleo
reviewed
Nov 7, 2022
| @@ -0,0 +1,6 @@ | |||
| # Support boot from IDE disks | |||
| CONFIG_ATA=y | |||
| CONFIG_ATA_GENERIC=y | |||
There was a problem hiding this comment.
Do we want the generic driver? We do not ship it with the metal variants.
If we actually want it, we probably also want it on metal.
There was a problem hiding this comment.
On a second look, indeed, this won't be needed. I'll drop it in the next revision.
Relevant code to boot from IDE disks needs to be built-in, not a module, as without disk drivers the kernel cannot load any modules. SCSI code needs to be pulled in since libata treats IDE disks as a SCSI device. Signed-off-by: Markus Boehme <[email protected]>
Signed-off-by: Markus Boehme <[email protected]>
markusboehme
force-pushed
the
feature/hybrid-environments
branch
from
88cec92
to
2e5458b
Compare
|
Dropped Refreshed summary of kernel config changes: The full diff of changes can be seen in this gist. |
jpculp
approved these changes
Nov 9, 2022
foersleo
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: n/a
Description of changes: Add driver support for using aws variants in hybrid environments. In particular, add support for booting from IDE/ATA devices and 5th generation Mellanox NICs.
Testing done: I collected kernel config diffs using
tools/diff-kernel-config, build-testing relevant configurations. This is the overview:Note that as expected only aws variants have their config changed. You can find a full config diff in this gist. Interesting to see that the 5.10 kernel for aarch64 almost had the desired configuration already. Feature selection for the mlx5 driver mirrors the existing configuration for metal variants.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.