Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match existing kubelet-config`s in kubernetes-1.24 #2539

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

arnaldo2792
Copy link
Contributor

Issue number:

Closes #2538

Description of changes:

In #2437, we added support for kubernetes 1.24, but I missed the change introduced by #2436.

Testing done:

  • I checked the default values for kubeAPIQPS and kubeAPIBurst were used when none were provided in the API
  • I checked the configuration file was re-rendered when the API changed
# Default
bash-5.1# cat /etc/kubernetes/kubelet/config  | grep QPS
kubeAPIQPS: 10
# New value
bash-5.1# apiclient set kubernetes.kube-api-qps=20
bash-5.1# cat /etc/kubernetes/kubelet/config  | grep QPS
kubeAPIQPS: 20
# New value
bash-5.1# apiclient set kubernetes.kube-api-burst=30
bash-5.1# cat /etc/kubernetes/kubelet/config  | grep Burst
kubeAPIBurst: 30

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

When the kubernetes-1.24 package was added, the `kube-config`
file in the package didn't include the new logic to render `kubeAPIQPS`
and `kubeAPIBurst`, introduced by 2fb74d5.  This reconciles the
drifted configuration with existing files.

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
@arnaldo2792 arnaldo2792 merged commit b3c35ca into bottlerocket-os:develop Nov 1, 2022
@arnaldo2792 arnaldo2792 deleted the add-qps-k8s-1.24 branch June 19, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

increase API QPS limits for kubelet 1.24
3 participants