switch to latest Dockerfile frontend for builds #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the Dockerfile syntax for passing secrets to builds. Signed-off-by: Ben Cressey <[email protected]>
stmcginnis
approved these changes
Oct 15, 2022
etungsten
approved these changes
Oct 17, 2022
jpculp
approved these changes
Oct 17, 2022
zmrow
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Update the Dockerfile from
1.1.3-experimentalto1.4.3. (It's been a while!)My goal is to enable the Dockerfile syntax for
RUN --mount=type=secret, since these secrets will be used for Secure Boot signing.It's possible there will be some backwards compatibility headaches here for older versions of Docker, so I'd like to get this merged early in a release cycle to shake out any problems.
Testing done:
Builds for me!
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.