Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs-gpu-init: Upgrade Go module go directive to 1.18 #2440

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Sep 19, 2022

Issue number:

Related: #2420

Description of changes:

This upgrades the Go build directive in the go module for ecs-gpu-init to reflect the version we use in the SDK. Should be a very low risk change and Go 1.16 has been out of support for awhile now

Testing done:

Able to build Go the code: go build ./cmd/ecs-gpu-init 👍🏼
Able to build the package: cargo make -e PACKAGE=ecs-gpu-init pacakge 👍🏼

Not sure if this requires more extensive testing since it builds ok

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@arnaldo2792
Copy link
Contributor

Could you please make sure ECS tasks that require GPUs are still working? 😄

@jpmcb
Copy link
Contributor Author

jpmcb commented Sep 22, 2022

Built an nvidia variant AMI and started a p2.xlarge GPU instance for my ECS cluster.

Then, on inspecting the nvidia-gpu-info.json file on the host 👍🏼

bash-5.1# cat /var/lib/ecs/gpu/nvidia-gpu-info.json
{"DriverVersion":"470.82.01","GPUIDs":["<GPU-ID>"]}
bash-5.1#

@jpmcb jpmcb merged commit 247a388 into bottlerocket-os:develop Sep 22, 2022
@jpmcb jpmcb deleted the ecs-gpu-go-bump branch September 22, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants