testsys: Update testsys commit to 07b9ae8
#2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etungsten
approved these changes
Aug 31, 2022
stmcginnis
approved these changes
Aug 31, 2022
arnaldo2792
reviewed
Aug 31, 2022
| @@ -10,19 +10,19 @@ publish = false | |||
| anyhow = "1.0" | |||
| aws-config = "0.46" | |||
| aws-sdk-ec2 = "0.16" | |||
| bottlerocket-types = { git = "https://github.com/bottlerocket-os/bottlerocket-test-system", rev = "021e8d6", version = "0.1"} | |||
| bottlerocket-types = { git = "https://github.com/bottlerocket-os/bottlerocket-test-system", rev = "07b9ae8", version = "0.0.1"} | |||
There was a problem hiding this comment.
What needs to be done to track the latest commit/release?
bcressey
approved these changes
Aug 31, 2022
| @@ -493,6 +496,7 @@ impl AwsEcs { | |||
| }, | |||
| spec: ResourceSpec { | |||
| depends_on: None, | |||
| conflicts_with: None, | |||
There was a problem hiding this comment.
I'd like for ResourceSpec to implement the Default trait so we can populate these None fields automatically via ..Default::default().
| bottlerocket-variant = { version = "0.1", path = "../../sources/bottlerocket-variant" } | ||
| clap = { version = "3", features = ["derive", "env"] } | ||
| env_logger = "0.9" | ||
| futures = "0.3.8" | ||
| k8s-openapi = { version = "0.15", features = ["v1_20", "api"], default-features = false } | ||
| log = "0.4" | ||
| maplit = "1.0.2" | ||
| model = { git = "https://github.com/bottlerocket-os/bottlerocket-test-system", rev = "021e8d6", version = "0.1"} | ||
| model = { git = "https://github.com/bottlerocket-os/bottlerocket-test-system", rev = "07b9ae8", version = "0.0.1"} |
There was a problem hiding this comment.
We probably want to rename model to something like bottlerocket-test-model that doesn't clash with a published crate. bottlerocket-types could be bottlerocket-test-types also.
ecpullen
added a commit
to ecpullen/bottlerocket
that referenced
this pull request
Oct 25, 2022
This update was partially completed in bottlerocket-os#2392. Image locations have been updated and e2e repo config for sonobuoy agents has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #N/A
Description of changes:
This PR updates the checkout of testsys to the later version of testsys.
Updating testsys includes:
testsys statusThis pr will precede a declarative testing pr that introduces
Test.tomlTesting done:
cargo make testand other targets work as expected.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.