Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc: update to 1.1.4 #2380

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented Aug 25, 2022

This change adds patches to fix broken kubectl exec.
opencontainers/runc#3559

Description of changes:

    update runc to 1.1.4

    New version runc fixs broken `kubectl exec`.

Testing done:
Test a build with this change on differnernt variants and check if it's able to kubectl exec the pods

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@gthao313 gthao313 marked this pull request as ready for review August 25, 2022 21:36
@gthao313 gthao313 changed the title runc: Add patches from runc/#3559 runc: update to 1.1.4 Aug 25, 2022
@bcressey
Copy link
Contributor

The change looks good to me. Commit message has some typos and CI looks unhappy for some reason.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is good, commit message still has a few typos. Should probably read like this:

New version of runc fixes broken `kubectl exec`

New version of runc fixes broken `kubectl exec`
@gthao313 gthao313 merged commit 2c06267 into bottlerocket-os:develop Aug 29, 2022
@gthao313 gthao313 deleted the runc-patch branch August 29, 2022 17:46
@kdaula kdaula added this to the 1.9.2 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants