metal: hw enablement of 10G+ networking equipment #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder intels networking configuration so that they are all in proximity to each other and in the same order as their definition in the Kconfig file for easier comparability. No functional change. Signed-off-by: Leonard Foerster <[email protected]>
The main drivers we are interested in here are I40E, ICE, and FM10K.
Explicitly setting the resulting options as follows:
* Disable DCB for I40E, we likely do not need DCB
* Disable IB support for I40E (and ICE on 5.15):
*5.10: INFINIBAND_I40IW
*5.15: INFINIBAND_IRDMA
* Enable PLDMFW firmware update format through PLDM needed by ICE
Signed-off-by: Leonard Foerster <[email protected]>
We are interested in AMD_XGBE. Explicitly disable DCE for that driver as we likely do not need DCB. In addition this driver will select option AMD_XGBE_HAVE_ECC on X86 platforms. As this config fragment is used on both x86 and aarch64 platforms we can not explicitly set it. Signed-off-by: Leonard Foerster <[email protected]>
Signed-off-by: Leonard Foerster <[email protected]>
For now disable support for DCB for these devices as well as the Infiniband support, Crypto offloading capabilities, and the ISCSI target driver. Signed-off-by: Leonard Foerster <[email protected]>
In order for the Emulex driver to be of use we additionally need to add the chipset drivers for BE2, BE3, Lancer and Skyhawk chipsets. Signed-off-by: Leonard Foerster <[email protected]>
Signed-off-by: Leonard Foerster <[email protected]>
Explicitly set the resulting DCA support for that driver to its default value. Signed-off-by: Leonard Foerster <[email protected]>
Signed-off-by: Leonard Foerster <[email protected]>
The main drivers here are SFC and SFC_FALCON. In addition configure the options for these drivers to support HWMON (SFC_MCDI_MON) and SRIOV. Disable SFC_MCDI_LOGGING as that is not needed (debug logging for communication between driver and firmware). Signed-off-by: Leonard Foerster <[email protected]>
foersleo
force-pushed
the
hw_enablement
branch
from
42fad36
to
51cbc93
Compare
|
Force push fixed the two bugs I had missed before sending this. Currently running the |
|
Update kernel-config diff in the gist linked above and the statistics after the last change. |
markusboehme
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2361 #2246
Closes #2361
Description of changes:
Enable 10G+ networking equipment for the metal variants for most vendors. While there is some cards that provide quite some advanced network features we are aiming for a meaningful minimum here, by enabling mostly the base Ethernet capabilities for these devices.
For advanced features we will have a separate discussion on if we need these out of the box or if those are valuable at all in the Bottlerocket use case. Features that I have identified and will discuss with the team: Infiniband support, DCB, Fibre Channel, SCSI/ISCSI (target) capabilities, offloading capabilities for some of the hardware (crypto offloading, flow processing).
As it is easier to add those features in later than to add them now and disable them later I have aimed for as few special features as possible.
For any Options resulting from enabling a specific device family I have explicitly set those to the desired setting.
The following options are not set explicitly as those are device families that the kernel has disabled by default:
Let's discuss if we we want to set those explicitly or if we are fine with these devices being disabled implicitly. Given that all these drivers are for older hardware it is reasonable to assume that they will not change their default down the line.
In addition there is option
AMD_XGBE_HAVE_ECCwhich is set conditionally based on the architecture beingX86whenAMD_XGBEis set. As we currently do not have separate config fragments foraarch64andx86_64we can not explicitly set it without causing trouble.Testing done:
Built some versions and compared resulting kernel configurations with the tooling currently under review in #2368
The full resulting config diff-report can be found in https://gist.github.com/foersleo/918342143826d4291c6d84bcc4e18194
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.