kernel: Disable drivers for USB-attached network interfaces #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to support USB-attached network interfaces in the cloud, and such devices are equally unlikely to be encountered in servers. Make sure not to build any drivers for them as they would just be dead weight. Signed-off-by: Markus Boehme <[email protected]>
|
Do we still want these for metal and homelab types of deployments? They may be needed for those types of hardware setups. cc @mchaker |
|
In the case of a homelab variant, a separate kernel config would be necessary -- there would be a lot of hardware to support that shouldn't weigh down the official metal variant kernel config. |
bcressey
approved these changes
Aug 10, 2022
foersleo
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: n/a
Description of changes: There is no need to support USB-attached network interfaces in the cloud, and such devices are equally unlikely to be encountered in servers. Make sure not to build any drivers for them as they would just be dead weight.
We had those drivers for the 5.4 kernel variants (last
aws-k8s-1.19, now gone) already and picked them up for the 5.10 kernel variants (any variants except*-dev) with release 1.9.0. This reverses course for the 5.10 kernel and ensures future upstream changes won't bring those drivers into the 5.15 kernel.Testing done:
The full list of resulting config changes can be found in this Gist.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.