File case convention contrib guide #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle J. Davis <[email protected]>
Signed-off-by: Kyle J. Davis <[email protected]>
mchaker
approved these changes
Jul 27, 2022
stmcginnis
approved these changes
Jul 28, 2022
| - All caps is used for documents and licenses (e.g. `PUBLISHING.md`, `TRADEMARKS.md`), | ||
| - All lower case is used for all other files (e.g. `sample-eksctl.yaml`, `main.rs`). | ||
|
|
||
|
|
There was a problem hiding this comment.
Just pointing out a nit, but if we enable markdown linting it will complain about an extra newline here. That said, if and when we do enable that, there will be plenty of other things to clean up, so this really doesn't matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kyle J. Davis [email protected]
Issue number: N/a
Description of changes: Adds note to the contributing guide that outlines how filenames should be capitalized or not.
Testing done: Eyeballs.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.