Update sources to use AWS SDK Rust #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've verified that the sundog/pluto proxy testing from #2227 still works as expected. |
etungsten
approved these changes
Jul 26, 2022
| @@ -1,10 +1,10 @@ | |||
| use std::str::FromStr; | |||
|
|
|||
jpculp
approved these changes
Jul 26, 2022
etungsten
reviewed
Jul 26, 2022
| @@ -57,6 +46,11 @@ pub(super) async fn get_cluster_network_config( | |||
| .find(|env_var| *env_var != Err(env::VarError::NotPresent)) | |||
| .and_then(|s| s.ok()); | |||
|
|
|||
| let config = aws_config::from_env() | |||
| .region(Region::new(region.to_owned())) | |||
There was a problem hiding this comment.
I'm a little weirded out by the fact that aws_sdk_rust doesn't attempt to do validation on the input string. We also don't do any validation on settings.aws.regions. I'm assuming this just takes whatever is given here and generates API endpoints. Just something to keep in mind.
There was a problem hiding this comment.
We could probably make some guesses surrounding what a region name looked like, but, I feel like we open ourselves to being broken every time a new region is released by doing so.
bcressey
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
1968
Description of changes:
Updates pluto and cfsignal in sources to use AWS SDK Rust.
Testing done:
Unit testing and built image locally.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.