host-ctr: add a mount for system logs #2295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchaker
force-pushed
the
mchaker-2022-07-mount-logs
branch
from
1dc9166
to
10e589e
Compare
|
Latest force push: added a mention of the log visibility in the README. |
arnaldo2792
requested changes
Jul 22, 2022
README.md
Outdated
| @@ -909,6 +909,8 @@ ssh -i YOUR_KEY_FILE \ | |||
|
|
|||
| For a list of what is collected, see the logdog [command list](sources/logdog/src/log_request.rs). | |||
|
|
|||
| Log archives are also visible to host containers. | |||
There was a problem hiding this comment.
Nit: move this line a few lines above, before "You can use SSH", and say something like:
This archive is accessible from host containers at `<blah>`.
....
10e589e
to
d1b92b6
Compare
|
Latest force push: revise README documentation |
bcressey
requested changes
Jul 22, 2022
mchaker
force-pushed
the
mchaker-2022-07-mount-logs
branch
from
d1b92b6
to
0022e8d
Compare
|
Latest force push: change mount destination directory to align with directory purposes |
bcressey
reviewed
Jul 25, 2022
| @@ -896,6 +896,7 @@ logdog | |||
| ``` | |||
|
|
|||
| This will write an archive of the logs to `/var/log/support/bottlerocket-logs.tar.gz`. | |||
| This archive is accessible from host containers at `/.bottlerocket/support`. | |||
There was a problem hiding this comment.
You can also fix the URL in the code block below to reflect this path.
Add a container-visible mount for /var/log/support, which contains system logs.
mchaker
force-pushed
the
mchaker-2022-07-mount-logs
branch
from
0022e8d
to
3bd7ae5
Compare
|
Latest force push: fix sample SSH command referencing the new log mount path |
bcressey
approved these changes
Jul 26, 2022
arnaldo2792
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2196
Description of changes:
Add a container-visible mount for /var/log/support,
which contains system logs.
Testing done:
aws-devhost and checked that both the control and admin containers could see/.bottlerocket/support/aws-devhost, ranlogdogundersheltieand checked that I could see the generated file in the control container.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.