Add new ECS variants #2286
Closed
Add new ECS variants #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the sources to compile the 515 NVIDIA driver for the 5.15 kernel. This version only supports the GPU architectures Maxwell, Pascal, Volta, Turing, Ampere, and forward. The driver will use the GPU System Processor (GSP) feature if the underlying hardware supports it by loading the binary file `/lib/firmware/nvidia/<version>/gsp.bin`. Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
mchaker
approved these changes
Jul 18, 2022
Comment on lines
+874
to
+875
| * 470.X | ||
| * 515.X |
There was a problem hiding this comment.
Would it be helpful to add the corresponding Bottlerocket versions alongside the NVIDIA driver numbers?
e.g.
470.X: Bottlerocket v0.X - v0.Y
515.X: Bottlerocket v0.A - v0.B
jpculp
approved these changes
Jul 19, 2022
| * 515.X | ||
|
|
||
| The official AMIs for these variants can be used with EC2 GPU-equipped instance types such as: `p2`, `p3`, `p4`, `g3`, `g4dn`, `g5` and `g5g`. | ||
| Some of these instance types are built with hardware that is no longer supported by the 515.X NVIDIA driver. |
There was a problem hiding this comment.
I might rephrase this as:
Suggested change
| Some of these instance types are built with hardware that is no longer supported by the 515.X NVIDIA driver. | |
| Note that older instance types, such as 'p2', are not supported by NVIDIA driver 515.X and above. |
Comment on lines
4
to
+7
| "aws-ecs-1", | ||
| "aws-ecs-1.1", | ||
| "aws-ecs-1-nvidia", | ||
| "aws-ecs-1.1-nvidia", |
There was a problem hiding this comment.
nit. While neither this, nor the above, is quite alphabetical, this might be more consistent with the rest:
Suggested change
| "aws-ecs-1", | |
| "aws-ecs-1.1", | |
| "aws-ecs-1-nvidia", | |
| "aws-ecs-1.1-nvidia", | |
| "aws-ecs-1", | |
| "aws-ecs-1-nvidia", | |
| "aws-ecs-1.1", | |
| "aws-ecs-1.1-nvidia", |
Same goes for the README.md.
|
I'm closing this since we are still working on our tooling to improve the release process for ECS variants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #2164
Description of changes:
Testing done:
p2instances since those are no longer supported for in this driver:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.