fix ntp service restart when settings change #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the service is named "ntp" rather than "chronyd", the restart commands were not run when NTP settings changed. Signed-off-by: Ben Cressey <[email protected]>
Ensure that existing hosts get the fix to properly restart the NTP service on upgrade. Signed-off-by: Ben Cressey <[email protected]>
mchaker
approved these changes
Jul 11, 2022
markusboehme
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
This PR was a helpful exercise for me. Leaving this here for someone to correct me if my understanding is wrong: The mix-up happened because Bottlerocket's API and model just talk of an NTP service in the abstract, whereas currently this is implemented via Chrony (chrony systemd service). The API and thar-be-settings only care about the generic service name. The fact it's Chrony is hidden in the model and considered an implementation detail.
etungsten
approved these changes
Jul 11, 2022
That's right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Since the service is named "ntp" rather than "chronyd", the restart commands were not run when NTP settings changed.
Testing done:
Confirmed that both newly launched and upgraded hosts restart the NTP service after settings change.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.