Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Adds nvidia ecs variant to README #2244

Merged

Conversation

stockholmux
Copy link
Member

Signed-off-by: Kyle J. Davis [email protected]

Issue number: n/a

Description of changes: Adds ecs nvidia variant to the readme

Testing done: eyeballs only

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase locally to squash the commits together?

README.md Outdated Show resolved Hide resolved
@stockholmux
Copy link
Member Author

@bcressey Done.
@arnaldo2792 Can you re-review to unblock merging?

@bcressey bcressey dismissed arnaldo2792’s stale review June 28, 2022 23:48

concerns addressed

@stockholmux stockholmux merged commit 1ba9ac7 into bottlerocket-os:develop Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants