Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused crates #2238

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Conversation

arnaldo2792
Copy link
Contributor

Issue number:
N / A

Description of changes:
After #1983, nothing used growpart

* sources: remove unused crate growpart

From 1709

$1.00 if we delete servicedog since we haven't used it for anything in over a year

^ and that was almost 1 year ago, so we have been shipping servicedog for ~2 years 😄

* sources: remove unused crate servicedog

Testing done:

  • Build Bottlerocket
  • Booted a VM, without any failures:
bash-5.1# apiclient get os
{
  "os": {
    "arch": "x86_64",
    "build_id": "eccb14f5",
    "pretty_name": "Bottlerocket OS 1.8.0 (aws-dev)",
    "variant_id": "aws-dev",
    "version_id": "1.8.0"
  }
}

bash-5.1# systemctl status
● ip-172-31-61-1.us-west-2.compute.internal
    State: running
     Jobs: 0 queued
   Failed: 0 units

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/os/os.spec Outdated Show resolved Hide resolved
@bcressey
Copy link
Contributor

Seems like I owe you $2 😀

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
@arnaldo2792
Copy link
Contributor Author

( forced pushed fixed comment about the remaining line )

@arnaldo2792 arnaldo2792 merged commit 78da563 into bottlerocket-os:develop Jun 24, 2022
@arnaldo2792 arnaldo2792 deleted the remove-unused branch July 25, 2022 16:13
@arnaldo2792 arnaldo2792 mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants