Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add and update documentation for metal variants #2205

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Jun 9, 2022

Description of changes:

    Add HARDWARE.md
    
    This adds a new file HARDWARE.md meant to document the hardware that
    Bottlerocket is currently tested on, not necessarily all of the hardware
    that can currently boot Bottlerocket.
    Add PROVISIONING-METAL.md
    
    This adds a new document that describes the files and process needed to
    provision Bottlerocket on a bare metal machine.
    README.md: Update for metal
    
    Updates README.md to add some additional information for metal variants.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@zmrow zmrow requested review from bcressey and etungsten June 9, 2022 21:44
PROVISIONING-METAL.md Outdated Show resolved Hide resolved
HARDWARE.md Outdated
@@ -0,0 +1,13 @@
# Bottlerocket test hardware
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this could be consolidated with the PROVISIONING-METAL doc, and I wonder if that one should be called QUICKSTART-METAL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the hardware felt worthy of it's own doc rather than buried in other metal documentation.

Re: QUICKSTART-METAL, I opted not to create a "quickstart" type doc since provisioning bare metal machines isn't really prescriptive like we can be with AWS variants; "run this command to start an instance", etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the hardware felt worthy of it's own doc rather than buried in other metal documentation.

Re: QUICKSTART-METAL, I opted not to create a "quickstart" type doc since provisioning bare metal machines isn't really prescriptive like we can be with AWS variants; "run this command to start an instance", etc.

Makes sense. I'm still wondering if HARDWARE.md and PROVISIONING-METAL.md should be consolidated instead of being separate documents. Maybe METAL.md?

@zmrow
Copy link
Contributor Author

zmrow commented Jun 10, 2022

^ addresses @etungsten 's comments

@zmrow zmrow marked this pull request as ready for review June 17, 2022 19:01
@zmrow
Copy link
Contributor Author

zmrow commented Jun 17, 2022

  • Finished hardware table
  • Moved out of draft

@zmrow zmrow requested a review from etungsten June 17, 2022 19:02
HARDWARE.md Outdated
@@ -0,0 +1,13 @@
# Bottlerocket test hardware
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the hardware felt worthy of it's own doc rather than buried in other metal documentation.

Re: QUICKSTART-METAL, I opted not to create a "quickstart" type doc since provisioning bare metal machines isn't really prescriptive like we can be with AWS variants; "run this command to start an instance", etc.

Makes sense. I'm still wondering if HARDWARE.md and PROVISIONING-METAL.md should be consolidated instead of being separate documents. Maybe METAL.md?

HARDWARE.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
HARDWARE.md Outdated Show resolved Hide resolved
HARDWARE.md Outdated Show resolved Hide resolved
PROVISIONING-METAL.md Outdated Show resolved Hide resolved
PROVISIONING-METAL.md Outdated Show resolved Hide resolved
PROVISIONING-METAL.md Outdated Show resolved Hide resolved
PROVISIONING-METAL.md Outdated Show resolved Hide resolved
PROVISIONING-METAL.md Show resolved Hide resolved
Settings prefixed with `init` are added to the kernel command line after the `--`, but before any existing init parameters.

In the example below, two console devices are set up, and `systemd`'s log level is set to `debug`.
It is important to note that the kernel will output to both console devices, but `systemd` outputs to the last device in line (`ttyS1,115200n8` in the example below).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add this note below, although it feels a bit discursive.

PROVISIONING-METAL.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@zmrow
Copy link
Contributor Author

zmrow commented Jun 27, 2022

^ Address all comments

@zmrow zmrow requested review from bcressey and etungsten June 27, 2022 15:55
The Bottlerocket SDK provides the `bootconfig` CLI tool, which is used to create a Boot Configuration initrd.
To create the Boot Configuration initrd, create a config file named `bootconfig-input` containing your desired key/value pair kernel and init arguments.

Then run the following (you will need Docker installed):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention the related cargo make tasks as another option in addition to the docker run commands?

@zmrow
Copy link
Contributor Author

zmrow commented Jun 27, 2022

^ Fix the HP model number in the supported hardware table

@zmrow
Copy link
Contributor Author

zmrow commented Jun 28, 2022

^ I made a mistake with the HP model number, it's correct now.

PROVISIONING-METAL.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
SUPPORTED-HARDWARE.md Outdated Show resolved Hide resolved
This adds a new file SUPPORTED-HARDWARE.md meant to document the
hardware that Bottlerocket is currently tested on, as well as hardware
known by the community to work with Bottlerocket.
This adds a new document that describes the files and process needed to
provision Bottlerocket on a bare metal machine.
Updates README.md to add some additional information for metal variants.
@zmrow
Copy link
Contributor Author

zmrow commented Jun 29, 2022

^ Addresses the last few nits

@zmrow zmrow merged commit 978084a into bottlerocket-os:develop Jun 29, 2022
@zmrow zmrow deleted the provisioning branch June 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants