Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws-k8s-1.18 variant #2044

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Mar 31, 2022

Issue number:
Fixes #1942

Description of changes:

    Remove aws-k8s-1.18 variant
    
    EKS ended 1.18 support on March 31st 2022.
    README: update example commands for fetching kmod kit
    
    The old example no longer worked due to tuftool download changes

Like #1807 removing 1.17, this removes the aws-k8s-1.18 variant. It's no longer supported by k8s upstream or EKS. Deprecation was communicated in the issue linked above and in the 1.6.0 release notes / changelog.

Testing done:
Confirmed that unit tests pass, 1.18 is no longer referenced and doesn't build, and 1.19 is still healthy.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍖

Copy link
Contributor

@arnaldo2792 arnaldo2792 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the version in the commit message be 1.18 instead of 1.17? Otherwise, approved.

EKS ended 1.18 support on March 31st 2022.
The old example no longer worked due to tuftool download changes
@etungsten
Copy link
Contributor Author

Push above fixes commit message

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚈

@etungsten etungsten merged commit cb57851 into bottlerocket-os:develop Apr 20, 2022
@etungsten etungsten deleted the remove-1.18 branch April 20, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate aws-k8s-1.18 variant by March 2022
6 participants