-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aws-k8s-1.18 variant #2044
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the version in the commit message be 1.18
instead of 1.17
? Otherwise, approved.
EKS ended 1.18 support on March 31st 2022.
The old example no longer worked due to tuftool download changes
Push above fixes commit message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚈
Issue number:
Fixes #1942
Description of changes:
Like #1807 removing 1.17, this removes the
aws-k8s-1.18
variant. It's no longer supported by k8s upstream or EKS. Deprecation was communicated in the issue linked above and in the 1.6.0 release notes / changelog.Testing done:
Confirmed that unit tests pass, 1.18 is no longer referenced and doesn't build, and 1.19 is still healthy.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.