Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup documentation #203

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Add setup documentation #203

merged 1 commit into from
Aug 29, 2019

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Aug 28, 2019

Addresses one bullet of #189.

This is an adaptation of our existing setup instructions for the repo. It's long enough that I think it should be a separate doc. Then, our README can be a bit shorter and less intimidating. :)

@tjkirch tjkirch requested a review from etungsten August 28, 2019 23:39
@tjkirch tjkirch mentioned this pull request Aug 28, 2019
8 tasks
Copy link
Contributor

@etungsten etungsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning this up!

INSTALL.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
@tjkirch
Copy link
Contributor Author

tjkirch commented Aug 29, 2019

This push addresses the feedback above; build dependencies are clarified and my random IDs are cleaned up.

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦑

@tjkirch tjkirch merged commit 4dfaa52 into develop Aug 29, 2019
@tjkirch tjkirch deleted the setup-docs branch August 29, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants