Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: lock tuftool install #2009

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

etungsten
Copy link
Contributor

Issue number:
N/A

Description of changes:
When we install tuftool, this locks the dependencies to the versions at
the time of tuftool's publication so random dependency changes won't
break our builds.

Testing done:
Can still build tuftool with an older rustc version that doesn't have edition 2021 features.

[ec2-user@ip-172-31-32-162 bottlerocket]$ cargo make tuftool
[cargo-make] INFO - cargo make 0.35.1
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: tuftool
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: tuftool
[cargo-make] INFO - Build Done in 230.38 seconds.
[ec2-user@ip-172-31-32-162 bottlerocket]$ rustc --version
rustc 1.51.0 (2fd73fabe 2021-03-23)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

When we install tuftool, this locks the dependencies to the versions at
the time of tuftool's publication so random dependency changes won't
break our builds.
@etungsten etungsten requested a review from webern March 18, 2022 17:40
@etungsten etungsten merged commit c7958c0 into bottlerocket-os:develop Mar 18, 2022
@etungsten etungsten deleted the tuftool-locked branch March 18, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants