-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update glibc to 2.35 #1977
update glibc to 2.35 #1977
Conversation
For x86_64:
For aarch64:
Pretty clear that the cross-compiling path isn't being taken, or else we'd skip these tests. |
Trying a slightly different invocation for installing the C.UTF-8 locale, under the theory that we're not finding |
Ugh. I promise this all works fine locally! Something strange is happening on the CI build hosts. |
"Something strange" is that I have a newer kernel on my development host, and also ended up with the QEMU static programs installed, which masks both these errors. |
28c85a0
to
9f0f84e
Compare
Need this fix for chronyd's seccomp filter: |
Signed-off-by: Ben Cressey <[email protected]>
Add current patches from the release branch. The C.UTF-8 locale is now upstream, so we no longer need the Fedora patches that add it. Since it's not built-in, we need to generate and install the corresponding files, which means building `localedef` for the build host's architecture as well. `--enable-static-pie` is now the default for architectures where it's supported, so we no longer need to pass that option. Exclude the new `ld.so` link since we don't need it, and `ldd` since it's a shell script. `catchsegv` and `libSegFault.so` were removed upstream. Signed-off-by: Ben Cressey <[email protected]>
(rebase only) |
(add chronyd patch for glibc 2.3.5, add latest glibc patches) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
🌶️
Issue number:
#1976
Description of changes:
Updated glibc to 2.35. Refreshed patches, adjusted configure options, and added C.UTF-8 to installed files.
Testing done:
Verified that aarch64 and x86_64 variants built, joined a cluster, and passed conformance testing.
Confirmed that the C.UTF-8 locale was working as expected:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.