Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: TCMU support #1953

Merged
merged 2 commits into from
Feb 23, 2022
Merged

kernel: TCMU support #1953

merged 2 commits into from
Feb 23, 2022

Conversation

cvlc
Copy link
Contributor

@cvlc cvlc commented Feb 14, 2022

Issue number:
N/A (See AmazonLinux issue)

Description of changes:
Added the TCMU (LinuxIO user subsystem) feature support as a module to the Bottlerocket kernel. TCMU is a feature of the Linux kernel that exposes block devices (eg. virtual/physical disks) to user space via LinuxIO (LIO) - for storage fabric solutions, eg. Ceph iSCSI Gateway and Ondat. This enables those solutions to run on Bottlerocket.

Testing done:
Standard cargo build.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cvlc cvlc changed the title kernel: kernel: TCMU support Feb 14, 2022
@etungsten etungsten added the area/core Issues core to the OS (variant independent) label Feb 14, 2022
@bcressey
Copy link
Contributor

Looks reasonable to me. Just to confirm - the userspace solutions you have in mind would all be deployed via containers?

Is there a getting started guide focused on Kubernetes deployments for either of the solutions you mentioned? Ideally we'd add some smoke testing to our test clusters for this functionality.

@cvlc
Copy link
Contributor Author

cvlc commented Feb 16, 2022

Whoops, apologies for the close-reopen!

Yes, indeed, it is aimed at containers:

There are a few options for testing

@cvlc cvlc closed this Feb 16, 2022
@cvlc cvlc reopened this Feb 16, 2022
@arnaldo2792
Copy link
Contributor

I checked how the init container works, and it will attempt to load various kernel modules. I think the simple smoke test will be to attempt to do the same (load the kernel modules), and a more complete test could be to attempt to run the ondat-operator in Bottlerocket, which under the hood uses the referenced init container. Anyhow, looks good! Thanks @cvlc!

Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues core to the OS (variant independent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants