Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rust dependencies #1940

Merged
merged 8 commits into from
Feb 3, 2022
Merged

update rust dependencies #1940

merged 8 commits into from
Feb 3, 2022

Conversation

webern
Copy link
Contributor

@webern webern commented Feb 3, 2022

Issue number:

Closes #1933

Description of changes:

Update Rust dependencies they said. It will be easy I said.

Testing done:

Running some tests now

  • CI is happy with all builds
  • Ran aarch64 aws-ecs-1
    • ran a task
    • logged in vis ssm enabled admin container and used sudo sheltie
    • used apiclient to change the motd setting
  • x86 aws-k8s-1.21, Sonobuoy quick

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@webern webern changed the title Update update rust dependencies Feb 3, 2022
@webern webern marked this pull request as draft February 3, 2022 03:29
@webern webern marked this pull request as ready for review February 3, 2022 19:37
Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built an aws-k8s-1.21 (x86_64) AMI on my side and it looks good!

Makefile.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤹

@webern
Copy link
Contributor Author

webern commented Feb 3, 2022

^ make the tuftool version a Makefile variable.

@webern
Copy link
Contributor Author

webern commented Feb 3, 2022

^ undo variants/Cargo.lock change (???)

@jpculp
Copy link
Member

jpculp commented Feb 3, 2022

I think you want to keep the version = 3 in the variants/Cargo.lock. We already have it in tools and sources.

@webern webern merged commit 67e5abf into bottlerocket-os:develop Feb 3, 2022
@webern webern deleted the update branch February 3, 2022 22:23
@bcressey bcressey mentioned this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin tuftool to known good version
5 participants