Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-1.21: update ipv6 address comparison patch #1932

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

etungsten
Copy link
Contributor

@etungsten etungsten commented Jan 29, 2022

Issue number:
Resolves #1930

Description of changes:

Author: Erikson Tung <[email protected]>
Date:   Fri Jan 28 17:05:19 2022 -0800

    kubernetes-1.21: update ipv6 address comparison patch

Testing done:
Built aws-k8s-1.21 variant successfully.

Launched several nodes and got a few with internal IPv6 addresses that have 0 for some address segments and they all register to the cluster fine:

$ kubectl --kubeconfig ipv6-test-config get nodes -o jsonpath='{range .items[*]}{.metadata.name} {.status.addresses[?(@.type=="InternalIP")].address}{"\n"}'
ip-192-168-18-172.us-west-2.compute.internal 2600:1f13:73a:fc00:0:0:0:ea26
ip-192-168-22-4.us-west-2.compute.internal 2600:1f13:73a:fc00:0:0:0:ea2c
ip-192-168-31-46.us-west-2.compute.internal 2600:1f13:73a:fc00:0:0:0:ea2b
ip-192-168-35-227.us-west-2.compute.internal 2600:1f13:73a:fc01:0:0:0:7768
ip-192-168-48-155.us-west-2.compute.internal 2600:1f13:73a:fc01:0:0:0:7764
ip-192-168-57-50.us-west-2.compute.internal 2600:1f13:73a:fc01:0:0:0:776b
ip-192-168-64-9.us-west-2.compute.internal 2600:1f13:73a:fc02:0:0:0:c166
ip-192-168-7-203.us-west-2.compute.internal 2600:1f13:73a:fc00:0:0:0:ea28
ip-192-168-72-90.us-west-2.compute.internal 2600:1f13:73a:fc02:0:0:0:c165
ip-192-168-91-5.us-west-2.compute.internal 2600:1f13:73a:fc02:0:0:0:c16a

I can kubectl exec and kubectl logs from any pod running on these nodes:

$ kubectl --kubeconfig ipv6-test-config get pods -A --field-selector spec.nodeName=ip-192-168-7-203.us-west-2.compute.internal
NAMESPACE     NAME               READY   STATUS    RESTARTS   AGE
kube-system   aws-node-2nzc8     1/1     Running   0          17m
kube-system   kube-proxy-4hgc4   1/1     Running   0          17m

$ kubectl --kubeconfig ipv6-test-config logs aws-node-2nzc8 -n kube-system
{"level":"info","ts":"2022-01-31T15:42:58.223Z","caller":"entrypoint.sh","msg":"Validating env variables ..."}
{"level":"info","ts":"2022-01-31T15:42:58.224Z","caller":"entrypoint.sh","msg":"Install CNI binaries.."}
{"level":"info","ts":"2022-01-31T15:42:58.241Z","caller":"entrypoint.sh","msg":"Starting IPAM daemon in the background ... "}
{"level":"info","ts":"2022-01-31T15:42:58.243Z","caller":"entrypoint.sh","msg":"Checking for IPAM connectivity ... "}
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    13  100    13    0     0  13000      0 --:--:-- --:--:-- --:--:-- 13000
{"level":"info","ts":"2022-01-31T15:43:02.268Z","caller":"entrypoint.sh","msg":"Copying config file ... "}
mv: setting attribute 'security.selinux' for 'security.selinux': Permission denied
{"level":"info","ts":"2022-01-31T15:43:02.275Z","caller":"entrypoint.sh","msg":"Successfully copied CNI plugin binary and config file."}
{"level":"info","ts":"2022-01-31T15:43:02.275Z","caller":"entrypoint.sh","msg":"Foregrounding IPAM daemon ..."}


$ kubectl --kubeconfig ipv6-test-config exec aws-node-2nzc8 -n kube-system -- ls
Defaulted container "aws-node" out of: aws-node, aws-vpc-cni-init (init)
10-aws.conflist
aws-cni
aws-cni-support.sh
aws-k8s-agent
aws-k8s-agent.log
bandwidth
egress-v4-cni
entrypoint.sh
grpc-health-probe
host-local
loopback
portmap

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending testing.

@etungsten etungsten force-pushed the newer-ipv6-k8s-patch branch 3 times, most recently from 4f24e1b to c27b39e Compare January 29, 2022 02:40
@etungsten etungsten marked this pull request as ready for review January 31, 2022 17:01
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫕

@etungsten etungsten merged commit 778a98f into bottlerocket-os:develop Feb 1, 2022
@etungsten etungsten deleted the newer-ipv6-k8s-patch branch February 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubelet: potential inconsistency with ipv6 node-ip comparison
5 participants