Add shimpei to inject runc prestart hooks #1868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
Related to #1799 , that PR is quite big. I'm taking some of the commits in that PR as their individual PR.
oci-add-hooks
is built as part of the release package, but it isn't included in any variant. Instead, packages that depend on it will include it in their spec file, as follows:Requires: %{_cross_os}oci-add-hooks
Testing done:
In the new variant created in #1799:
I created a new containerd configuration that calls
shimpei
instead of runc:The prestart hook in #1799, sets up GPUs and mounts helper binaries like
nvidia-smi
. In my test, I callednvidia-smi
in a GPU-enabled orchestrated container:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.