Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPMI kernel module to 5.10 kernel #1862

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

arnaldo2792
Copy link
Contributor

Issue number:
N / A

Description of changes:

Related to #1799 , that PR is quite big. I'm taking some of the commits in that PR as their individual PR. The commit in this PR is variant independent, since it changes a package used among all variants.

07d6bcf7 Add IPMI kernel module to 5.10 kernel

Testing done:

  • Build aws-dev and launched an instance
  • Confirmed that the kernel module can be loaded:
bash-5.0# modinfo ipmi_msghandler
filename:       /lib/modules/5.10.75/kernel/drivers/char/ipmi/ipmi_msghandler.ko
softdep:        post: ipmi_devintf
version:        39.2
description:    Incoming and outgoing message routing for an IPMI interface.
author:         Corey Minyard <[email protected]>
license:        GPL
srcversion:     6A1B2902B9322AFBA64E5DC
depends:
retpoline:      Y
intree:         Y
name:           ipmi_msghandler
vermagic:       5.10.75 SMP mod_unload modversions
sig_id:         PKCS#7
signer:
sig_key:
sig_hashalgo:   unknown
signature:
parm:           panic_op:Sets if the IPMI driver will attempt to store panic information in the event log in the event of a panic.  Set to 'none' for no, 'event' for a.
parm:           maintenance_mode_timeout_ms:The time (milliseconds) after the last maintenance message that the connection stays in maintenance mode. (ulong)
parm:           default_retry_ms:The time (milliseconds) between retry sends (ulong)
parm:           default_maintenance_retry_ms:The time (milliseconds) between retry sends in maintenance mode (ulong)
parm:           default_max_retries:The time (milliseconds) between retry sends in maintenance mode (uint)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
@zmrow
Copy link
Contributor

zmrow commented Dec 9, 2021

Is IPMI_HANDLER the only one needed here for the desired functionality? (I'm not sure what the GPU stuff needs).

What about IPMI_SI?

@arnaldo2792
Copy link
Contributor Author

@zmrow yes, IPMI_HANDLER is the only documented dependency for NVIDIA's kernel modules.

@arnaldo2792 arnaldo2792 merged commit 64c532e into bottlerocket-os:develop Dec 10, 2021
@arnaldo2792 arnaldo2792 deleted the ipmi-module branch December 10, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants